Add progress_bar option to image pull #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is what the progress bar looks like - it is basically a bar for each layer being pulled and switches from Downloading to Download complete when done.
|
|
Nice work LGTM |
|
/approve |
umohnani8
force-pushed
the
pull-progress
branch
5 times, most recently
from
6250a3c to
912b41d
Compare
Add a new arg option called progress_bar that when set to true will display a progress bar with the image pull progress. This uses the compat endpoint as that is the data we are able to parse to displat the progress bar. Signed-off-by: Urvashi Mohnani <[email protected]>
umohnani8
force-pushed
the
pull-progress
branch
from
912b41d to
f0739cc
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lsm5, rhatdan, umohnani8 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new arg option called progress_bar that when set to true will display a progress bar with the image pull progress. This uses the compat endpoint as that is the data we are able to parse to displat the progress bar.