Fix stream issues in container.top

[RazCrimson]

Changes:

• Add a common stream_helper to stream and decode json responses
• Switches existing methods to use the newer helper.
• Fixes Container.top issues mentioned in Streaming not supported in Container.top #249

The stream_helper would be useful when other APIs require streaming and JSON decoding like for the API mentioned in #239

Please do let me know in case something needs to be changed or amended.

Closes #249

[umohnani8]

Changes LGTM
@rhatdan @lsm5 @jwhonce PTAL

[jwhonce]

This changes the behaviour of stats() to read all the contents before returning the JSON payload. Given there is a streaming flag I don't see this change as wrong, just potentially breaking for developers who may be using the previous implementation.

[RazCrimson]

The change in loading the response was made in 3ad81a7
It has already been merged in #237 and released. 😅

Also the existing code before that had issues for non-stream mode, where it was encoding each character in the response with an \n appended. I ended up replacing it with a simple json.loads.

Snippet for Ref:

        with io.StringIO() as buffer:
            for entry in response.text:
                buffer.write(json.dumps(entry) + "\n")
            return buffer.getvalue()

Please feel free to suggest any better alternatives.
I'll make the required changes.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jwhonce, RazCrimson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jwhonce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[lsm5]

LGTM if @rhatdan and @jwhonce are happy.

@RazCrimson might wanna squash commits?

[RazCrimson]

@lsm5
Is this current level of squashing fine or would you like me to squash everything into one commit?

[lsm5]

@lsm5 Is this current level of squashing fine or would you like me to squash everything into one commit?

i was just checking if you needed / wanted to squash at all :) . Either way is fine by me.

Also, there's a ModuleNotFoundError now :(

[RazCrimson]

Weird, there are no actual changes in the files before and after squashing.

Triggering another build did not fix it too.

Any ideas? 🤔

[lsm5]

@cevich any idea whatsup with the fedora-37 failure?

[cevich]

@cevich any idea whatsup with the fedora-37 failure?

Unfortunately no, I encountered the same/similar errors while trying to update the CI VM images over in #251

I think we need a python-guru to take a look.

[mwhahaha]

Probably need to add extras into the requirements. It was removed from fixtures via testing-cabal/fixtures@f8df219 however we're using fixtures~=3.0.0. Could try bumping fixtures to 4.0.0 or including extras in the requirements.

[mwhahaha]

Fixing CI via #252

[lsm5]

@mwhahaha thanks! @RazCrimson rebasing should make CI green.

[RazCrimson]

@lsm5 Done!

[rhatdan]

LGTM