Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: modelName should be name #933

Merged
merged 1 commit into from
Apr 21, 2024
Merged

Conversation

jeffmaury
Copy link
Contributor

Fixes #932

What does this PR do?

Update the model property from modelName to name (expected by recipe)

Screenshot / video of UI

N/A

What issues does this PR fix or reference?

#932

How to test this PR?

  1. Start the object_detection recipe
  2. Go into the model server container
  3. Verify that the environment variable MODEl_NAME is set

@jeffmaury jeffmaury requested review from benoitf and a team as code owners April 19, 2024 14:30
@jeffmaury jeffmaury requested a review from feloy April 19, 2024 14:30
@jeffmaury jeffmaury enabled auto-merge (squash) April 19, 2024 14:30
@jeffmaury jeffmaury added this to the 1.1 milestone Apr 19, 2024
@jeffmaury jeffmaury self-assigned this Apr 19, 2024
@jeffmaury jeffmaury merged commit 27ed4d0 into containers:main Apr 21, 2024
4 checks passed
@jeffmaury jeffmaury deleted the GH-932 branch April 22, 2024 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

modelName attribute should be name
2 participants