Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding support for starting / stopping playground #93

Merged
merged 9 commits into from
Jan 19, 2024

Conversation

axel7083
Copy link
Contributor

@axel7083 axel7083 commented Jan 18, 2024

Fixes #20

Stopped

image

Running

image

Starting | Stopping

image

@feloy
Copy link
Contributor

feloy commented Jan 19, 2024

When I start, then stop a playground, I get the error when trying to restart it again:

Something went wrong on channel startPlayground: Error: model is already running

(the container has been succesfully stopped).

@axel7083 axel7083 force-pushed the feature/playground-state branch from 90095f3 to 57de3e5 Compare January 19, 2024 13:05
Signed-off-by: axel7083 <[email protected]>
Signed-off-by: axel7083 <[email protected]>
Signed-off-by: axel7083 <[email protected]>
@axel7083 axel7083 marked this pull request as ready for review January 19, 2024 13:16
@axel7083
Copy link
Contributor Author

When I start, then stop a playground, I get the error when trying to restart it again:

Something went wrong on channel startPlayground: Error: model is already running

(the container has been succesfully stopped).

Yeah it should be good now

@feloy
Copy link
Contributor

feloy commented Jan 19, 2024

I would replace the Playground none, when no playground is running, by something more meaningful (Playground is not running?)

@feloy feloy merged commit 57c27c7 into main Jan 19, 2024
3 checks passed
@feloy feloy deleted the feature/playground-state branch January 19, 2024 15:04
@axel7083
Copy link
Contributor Author

I would replace the Playground none, when no playground is running, by something more meaningful (Playground is not running?)

Agree but details for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add playground start / stop action
2 participants