-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add warning banner to recipe page #881
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great work, @lstocchi !
Needs a rebase to resolve the merge conflicts.
Signed-off-by: lstocchi <[email protected]>
Signed-off-by: Jeff MAURY <[email protected]>
Signed-off-by: Jeff MAURY <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After I started Podman Desktop, I try to create a recipe and it tells me that the Podman Machine is stopped and the status is never update even if my Podman Machine is started (checked from the CLI)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Just noted a side effect; it seems the check is updated even when the AI App is starting which may seem strange to users.
Also seems to me that there is an issue in Podman machine as it seems not to restore full memory and if you run several times start/stop of the application you may see the warning more and more
@jeffmaury ok, i'll merge this then. For the podman machine should we open an issue as well to investigate more and tell it to the podman team? Or maybe @vrothberg have some more info about it |
I think it's best to open an issue against Podman with a reproducer. |
What does this PR do?
This PR just have the code for adding the warning banner to the recipe page. It is based on #856
Screenshot / video of UI
What issues does this PR fix or reference?
it resolves #874
How to test this PR?