Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add warning banner to recipe page #881

Merged
merged 3 commits into from
Apr 16, 2024
Merged

Conversation

lstocchi
Copy link
Contributor

What does this PR do?

This PR just have the code for adding the warning banner to the recipe page. It is based on #856

Screenshot / video of UI

warning_recipe_2

What issues does this PR fix or reference?

it resolves #874

How to test this PR?

  1. same as feat: show warning if no machine is running or there are not enough resources (#227) #856 but on the recipe page

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great work, @lstocchi !

Needs a rebase to resolve the merge conflicts.

@jeffmaury jeffmaury marked this pull request as ready for review April 12, 2024 13:26
@jeffmaury jeffmaury requested review from benoitf and a team as code owners April 12, 2024 13:26
@jeffmaury jeffmaury requested a review from axel7083 April 12, 2024 13:26
lstocchi and others added 3 commits April 12, 2024 15:46
Signed-off-by: Jeff MAURY <[email protected]>
Signed-off-by: Jeff MAURY <[email protected]>
Copy link
Contributor

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After I started Podman Desktop, I try to create a recipe and it tells me that the Podman Machine is stopped and the status is never update even if my Podman Machine is started (checked from the CLI)

Copy link
Contributor

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Just noted a side effect; it seems the check is updated even when the AI App is starting which may seem strange to users.
Also seems to me that there is an issue in Podman machine as it seems not to restore full memory and if you run several times start/stop of the application you may see the warning more and more

@lstocchi
Copy link
Contributor Author

@jeffmaury ok, i'll merge this then.
Can you please open an issue elaborating a bit more about your first concern? I didn't get it tbh.

For the podman machine should we open an issue as well to investigate more and tell it to the podman team? Or maybe @vrothberg have some more info about it

@vrothberg
Copy link
Member

For the podman machine should we open an issue as well to investigate more and tell it to the podman team? Or maybe @vrothberg have some more info about it

I think it's best to open an issue against Podman with a reproducer.

@lstocchi lstocchi merged commit 9b4b559 into containers:main Apr 16, 2024
4 checks passed
@lstocchi lstocchi deleted the i874 branch April 16, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warn users if they are using a podman machine with few resources; recipe
3 participants