fix: frontend loading issue #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lstocchi
approved these changes
Jan 17, 2024
axel7083
force-pushed
the
fix/addresing-small-issues
branch
from
362e30d to
2014298
Compare
axel7083
force-pushed
the
fix/addresing-small-issues
branch
2 times, most recently
from
491825a to
a2b2b84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instead of having individual page adding the LinearProgress, I added it to the NavPage component, and a new loading prop.
When loading is set to true, the linear progress is used, and the content is hidden.
Screenshots
page-loading.mp4