-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add audio_to_text and object_detection recipes to the catalog #869
Conversation
Fixes containers#695 Signed-off-by: Jeff MAURY <[email protected]>
Signed-off-by: Jeff MAURY <[email protected]>
Signed-off-by: Jeff MAURY <[email protected]>
Signed-off-by: Jeff MAURY <[email protected]>
Be sure that you're actually using this PR. I'm running it now and i can see them. Maybe you forgot to build after switching branch? |
I verified to be using the right branch and ran |
aaaah ... I had to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested successfully 🏁 Great work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aaaah ... I had to
rm -rf ~/.local/share/containers/podman-desktop
for it to show up.
I want to raise an important issue (again) justifying why you had to delete the folder, because on my computer too the new recipes was not visible
As I mentionned in #771 (comment) and available in #792
If the user at some point imported manually a model, which is the expected behaviour, he will not see new recipes after an update.
Because we have a unique catalog for the models and recipes, and we do not make any difference between user's one vs native. We ended up with a situation where the new recipes you added was not visible in my catalog because I have a copy of an old one.
I used the one from the local clone as Jeff mentioned in the PR description:
|
@axel7083 that's what I must have hit as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After reading the doc where it explains that we must use a 16-bit WAV file i was able to create a custom audio file and use it on the app. Maybe we should add this inside the app itself.
Like Upload an audio file you wish to have translated (it only supports a 16-bit WAV files)
BTW works fine. Just the problem with the images Axel mentioned.
I opened containers/ai-lab-recipes#280 as this could be easy fixed by the application converting any audio to the expected format |
Fixes #695
What does this PR do?
Add 2 recipes to the catalog
Blocked by:
Screenshot / video of UI
N/A
What issues does this PR fix or reference?
#695
How to test this PR?
Start the 2 new recipes: