Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding @podman-desktop/ui-svelte #510

Merged

Conversation

axel7083
Copy link
Contributor

@axel7083 axel7083 commented Mar 12, 2024

What does this PR do?

Adding the @podman-desktop/ui-svelte library using 1.10.3.

Screenshot / video of UI

What issues does this PR fix or reference?

Fixes #1165

How to test this PR?

@axel7083 axel7083 requested a review from a team as a code owner March 12, 2024 14:04
@axel7083 axel7083 requested review from benoitf, jeffmaury and feloy March 12, 2024 14:04
@benoitf
Copy link
Collaborator

benoitf commented Mar 12, 2024

I think there is a missing entry in tailwind.config.js to scan svelte and css files from the@podman-desktop/ui-svelte in node_modules/

also maybe need to introduce it after 0.2.0 tag

Copy link
Collaborator

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a good time to introduce it

but it needs two things IMHO

@benoitf benoitf marked this pull request as draft April 4, 2024 10:14
@benoitf
Copy link
Collaborator

benoitf commented Apr 4, 2024

converting to draft as not updated

@axel7083 axel7083 force-pushed the feature/introduce-podman-svelte-ui-lib branch from 3696f5d to ab11c37 Compare June 6, 2024 09:19
@axel7083 axel7083 marked this pull request as ready for review June 6, 2024 09:19
@axel7083 axel7083 requested a review from a team as a code owner June 6, 2024 09:19
@axel7083 axel7083 requested review from benoitf and lstocchi June 6, 2024 09:19
@axel7083
Copy link
Contributor Author

axel7083 commented Jun 6, 2024

cc @benoitf

@axel7083 axel7083 merged commit 995665b into containers:main Jun 6, 2024
4 checks passed
mhdawson pushed a commit to mhdawson/podman-desktop-extension-ai-lab that referenced this pull request Nov 22, 2024
Fix invalid instructions in README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add @podman-desktop/ui-svelte to ai lab
2 participants