Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use proper wording for repo checkout #496

Merged
merged 1 commit into from
Mar 11, 2024
Merged

fix: use proper wording for repo checkout #496

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/backend/src/managers/applicationManager.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,7 +432,7 @@ describe('doCheckout', () => {
expect(cloneRepositoryMock).toBeCalledWith(gitCloneOptions);
expect(mocks.updateTaskMock).toHaveBeenLastCalledWith({
id: expect.any(String),
name: 'Checkout repository',
name: 'Checking out repository',
state: 'success',
labels: {
git: 'checkout',
Expand Down Expand Up @@ -472,7 +472,7 @@ describe('doCheckout', () => {
expect(cloneRepositoryMock).toBeCalledWith(gitCloneOptions);
expect(mocks.updateTaskMock).toHaveBeenLastCalledWith({
id: expect.any(String),
name: 'Checkout repository',
name: 'Checking out repository',
state: 'error',
labels: {
git: 'checkout',
Expand Down Expand Up @@ -512,7 +512,7 @@ describe('doCheckout', () => {
expect(cloneRepositoryMock).not.toHaveBeenCalled();
expect(mocks.updateTaskMock).toHaveBeenLastCalledWith({
id: expect.any(String),
name: 'Checkout repository (cached).',
name: 'Checking out repository (cached).',
state: 'success',
labels: {
git: 'checkout',
Expand Down
4 changes: 2 additions & 2 deletions packages/backend/src/managers/applicationManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -553,7 +553,7 @@ export class ApplicationManager extends Publisher<ApplicationState[]> {

async doCheckout(gitCloneInfo: GitCloneInfo, labels?: { [id: string]: string }) {
// Creating checkout task
const checkoutTask: Task = this.taskRegistry.createTask('Checkout repository', 'loading', {
const checkoutTask: Task = this.taskRegistry.createTask('Checking out repository', 'loading', {
...labels,
git: 'checkout',
});
Expand All @@ -562,7 +562,7 @@ export class ApplicationManager extends Publisher<ApplicationState[]> {
// We might already have the repository cloned
if (fs.existsSync(gitCloneInfo.targetDirectory) && fs.statSync(gitCloneInfo.targetDirectory).isDirectory()) {
// Update checkout state
checkoutTask.name = 'Checkout repository (cached).';
checkoutTask.name = 'Checking out repository (cached).';
checkoutTask.state = 'success';
} else {
// Create folder
Expand Down