refactor: using enum for message channel #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffmaury
reviewed
Mar 11, 2024
axel7083
force-pushed
the
refactor/using-enum-messages
branch
from
9a0a9f4 to
cbdc5c2
Compare
Agreed ✅ |
Signed-off-by: axel7083 <[email protected]>
Signed-off-by: axel7083 <[email protected]>
Signed-off-by: axel7083 <[email protected]>
axel7083
force-pushed
the
refactor/using-enum-messages
branch
from
cbdc5c2 to
d0f1530
Compare
mhdawson
pushed a commit
to mhdawson/podman-desktop-extension-ai-lab
that referenced
this pull request
Nov 22, 2024
…c-workflow-build split build and pull on bootc_training workflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We are declaring manually
export constwhich can lead to duplicates, and could create issue. Using an enum ensure we do not have duplicates in the channel used.Screenshot / video of UI
What issues does this PR fix or reference?
How to test this PR?