Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: introduce snippet manager #482

Merged
merged 6 commits into from
Mar 12, 2024
Merged

feat: introduce snippet manager #482

merged 6 commits into from
Mar 12, 2024

Conversation

axel7083
Copy link
Contributor

@axel7083 axel7083 commented Mar 11, 2024 •
edited by benoitf
Loading

What does this PR do?

Using the library open source postman-code-generators to generate code snippet.

Currently this only generate dummy get request snippet or a given URL. We can use this as a base to generate more complex snippet.

Screenshot / video of UI

What issues does this PR fix or reference?

Fixes #435

How to test this PR?

  • unit tests has been provided.

@axel7083 axel7083 requested a review from a team as a code owner March 11, 2024 10:46
@axel7083 axel7083 requested review from benoitf, jeffmaury and feloy March 11, 2024 10:46
jeffmaury
jeffmaury reviewed Mar 11, 2024
View reviewed changes
Copy link
Contributor

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have 2 interrogations:

  • seems language variant is mandatory can't it be optional
  • I see a lot of replacement from yarnpkg.com to npmjs.org that seems unrelated

@axel7083
Copy link
Contributor Author

  • seems language variant is mandatory can't it be optional

When using listLanguages() you get an array of Language which contains a list of variants. There will always have at least one.

  • I see a lot of replacement from yarnpkg.com to npmjs.org that seems unrelated

Weird indeed, I will take a look

@axel7083 axel7083 requested a review from jeffmaury March 11, 2024 16:02
@axel7083 axel7083 force-pushed the feature/introduce-snippet-manager branch from 7fd6088 to cda0e32 Compare March 11, 2024 17:29
@axel7083 axel7083 added the kind/feature 💡 Issue for requesting a new feature label Mar 12, 2024
@axel7083 axel7083 merged commit 4b5ad2f into containers:main Mar 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feloy feloy feloy approved these changes

@benoitf benoitf benoitf approved these changes

@jeffmaury jeffmaury Awaiting requested review from jeffmaury jeffmaury is a code owner

Assignees
No one assigned
Labels
kind/feature 💡 Issue for requesting a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Study the library postman-code-generators
4 participants
@axel7083 @benoitf @jeffmaury @feloy