Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove categories from catalog interface #463

Conversation

axel7083
Copy link
Contributor

@axel7083 axel7083 commented Mar 7, 2024

What does this PR do?

We need to clear out some old dependencies/requirements (we have some hardcoded recent category etc. which are not used), moreover categories where at the same level than Models and Recipe, removing for now.

We can re-introduce then later when we would have completed #447

Screenshot / video of UI

What issues does this PR fix or reference?

Fixes #461

How to test this PR?

  • existing tests ensure no regression

@axel7083 axel7083 requested a review from a team as a code owner March 7, 2024 17:04
Signed-off-by: axel7083 <[email protected]>
@jeffmaury
Copy link
Contributor

I don't understand the rationale for this. This is a change from the mockup and I don't remember being addressed during UI Call.
@slemeur @ekidneyrh WDYT ?

@axel7083
Copy link
Contributor Author

I don't understand the rationale for this. This is a change from the mockup and I don't remember being addressed during UI Call. @slemeur @ekidneyrh WDYT ?

If you want to split the models and the recipes. What do we do with the categories ?

@jeffmaury
Copy link
Contributor

I don't understand the rationale for this. This is a change from the mockup and I don't remember being addressed during UI Call. @slemeur @ekidneyrh WDYT ?

If you want to split the models and the recipes. What do we do with the categories ?

They are related to recipes (a way to group and display them)

@axel7083
Copy link
Contributor Author

I don't understand the rationale for this. This is a change from the mockup and I don't remember being addressed during UI Call. @slemeur @ekidneyrh WDYT ?

If you want to split the models and the recipes. What do we do with the categories ?

They are related to recipes (a way to group and display them)

Okey got it. I will close this PR and include the change in #464

@axel7083 axel7083 closed this Mar 11, 2024
mhdawson pushed a commit to mhdawson/podman-desktop-extension-ai-lab that referenced this pull request Nov 22, 2024
Reschedule testing framework workflow to run once a day
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove categories from Catalog
2 participants