Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(application): using publisher class to notify webview #459

Merged

Conversation

axel7083
Copy link
Contributor

@axel7083 axel7083 commented Mar 7, 2024

What does this PR do?

This PR is a refactor for the application manager to use the newest Publisher class introduced.

Screenshot / video of UI

What issues does this PR fix or reference?

How to test this PR?

  • existing tests ensure no regression

@axel7083 axel7083 requested a review from a team as a code owner March 7, 2024 15:26
@axel7083 axel7083 requested review from benoitf, jeffmaury and feloy March 7, 2024 15:26
@axel7083 axel7083 changed the title refactor(application): using publisher class for notify webview refactor(application): using publisher class to notify webview Mar 7, 2024
Copy link
Contributor

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@axel7083 axel7083 merged commit 63744c0 into containers:main Mar 8, 2024
4 checks passed
axel7083 added a commit to axel7083/ai-studio that referenced this pull request Mar 11, 2024
mhdawson pushed a commit to mhdawson/podman-desktop-extension-ai-lab that referenced this pull request Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants