fix: disable selinux label when mounting the volume for the playground #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes containers#456 Signed-off-by: Jeff MAURY <[email protected]>
axel7083
reviewed
Mar 7, 2024
| @@ -212,6 +212,7 @@ export class PlayGroundManager { | |||
| Type: 'bind', | |||
| }, | |||
| ], | |||
| SecurityOpt: [DISABLE_SELINUX_LABEL_SECURITY_OPTION], | |||
There was a problem hiding this comment.
What are the implication of this security option ? Why does it is required ? I cannot really understand the link with applehv from the documentation https://docs.podman.io/en/v4.6.1/markdown/options/security-opt.html
There was a problem hiding this comment.
The volumes are not readable if this option is not set on Linux and applehv. Inspired from containers/podman#3683
There was a problem hiding this comment.
So we might want to include this option on windows or we don't care ?
There was a problem hiding this comment.
It is set for all platforms, I prefer to have a single general flow
mhdawson
pushed a commit
to mhdawson/podman-desktop-extension-ai-lab
that referenced
this pull request
Nov 22, 2024
chore: handle some AVX flags properly on certain Intel CPUs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #456
What does this PR do?
Change options while starting the playground server
Screenshot / video of UI
N/A
What issues does this PR fix or reference?
#456
How to test this PR?
Start the playground for a model on Linux or MacOS applehv