Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ChatBot Readme): fix missing space after comma #448

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

vrothberg
Copy link
Member

Noticed while playing with the extension.

What does this PR do?

Fix a small issue in the readme.

Screenshot / video of UI

What issues does this PR fix or reference?

How to test this PR?

Build and look at the ChatBot Readme in the AI Studio.

Noticed while playing with the extension.

Signed-off-by: Valentin Rothberg <[email protected]>
@vrothberg vrothberg requested a review from a team as a code owner March 6, 2024 13:22
@vrothberg vrothberg requested review from benoitf, jeffmaury and feloy March 6, 2024 13:22
Copy link
Collaborator

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's in the text downloaded onto your host, model_services/builds

IMHO the fix is add space after comma and not add space before the comma

or 'missing space after comma`

@vrothberg
Copy link
Member Author

vrothberg commented Mar 6, 2024

Right, it's adding a space after not before. Want me to change?

@benoitf benoitf changed the title ChatBot README: add space before comma chore(ChatBot Readme): fix missing space after comma Mar 6, 2024
@benoitf
Copy link
Collaborator

benoitf commented Mar 6, 2024

I fixed the PR's title, I think it's ok

@benoitf benoitf merged commit adda3dd into containers:main Mar 6, 2024
3 checks passed
mhdawson pushed a commit to mhdawson/podman-desktop-extension-ai-lab that referenced this pull request Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants