Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ContainerRegistry): start container event listener #443

Merged

Conversation

axel7083
Copy link
Contributor

@axel7083 axel7083 commented Mar 5, 2024

What does this PR do?

Adding a startup event for the future InferenceManager (#434). Currently when a container is manually stop (and not removed) and start, we do not have access to this event.

This is because today, in the Playground when creating a container we use AutoRemove: true. We need to move out of this option.

Screenshot / video of UI

What issues does this PR fix or reference?

Related to #434

How to test this PR?

  • unit tests has been added

@axel7083 axel7083 requested a review from a team as a code owner March 5, 2024 15:03
@axel7083 axel7083 requested review from benoitf, jeffmaury and feloy March 5, 2024 15:03
@axel7083 axel7083 mentioned this pull request Mar 5, 2024
3 tasks
@axel7083 axel7083 force-pushed the feature/container-registry-start-event branch from f85ed04 to 68e3f3a Compare March 8, 2024 10:09
@axel7083 axel7083 merged commit cbfad85 into containers:main Mar 8, 2024
4 checks passed
axel7083 added a commit to axel7083/ai-studio that referenced this pull request Mar 11, 2024
* feat(ContainerRegistry): start container event listener

Signed-off-by: axel7083 <[email protected]>

* fix: prettier & linter

Signed-off-by: axel7083 <[email protected]>

* fix: linter

Signed-off-by: axel7083 <[email protected]>

* test(ContainerRegistry): ensuring call in expected time

Signed-off-by: axel7083 <[email protected]>

---------

Signed-off-by: axel7083 <[email protected]>
mhdawson pushed a commit to mhdawson/podman-desktop-extension-ai-lab that referenced this pull request Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants