Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add workflow for playground image #422

Closed
wants to merge 1 commit into from

Conversation

jeffmaury
Copy link
Contributor

Fixes containers/podman-desktop-extension-ai-lab-playground-images#2

What does this PR do?

Add workflow for publishing playground image(s)

Screenshot / video of UI

N/A

What issues does this PR fix or reference?

containers/podman-desktop-extension-ai-lab-playground-images#2

How to test this PR?

Check workflows

Fixes #375

Signed-off-by: Jeff MAURY <[email protected]>
@jeffmaury jeffmaury marked this pull request as ready for review February 26, 2024 17:13
@jeffmaury jeffmaury requested a review from a team as a code owner February 26, 2024 17:13
Copy link
Collaborator

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's worrying me that playground is in packages

the packages/* folder are yarn workspaces
https://github.com/projectatomic/ai-studio/blob/main/package.json#L50

so I would probably move the playground to another directory

but then, as it's not related to the same lifecycle I would move out to its own repository as anyway it's publishing its own package ai-studio-playground-chat I would expect to have then ai-studio-playground-chat repository with this Containerfile

@jeffmaury jeffmaury closed this Feb 29, 2024
@jeffmaury jeffmaury deleted the GH-375 branch February 29, 2024 09:24
mhdawson pushed a commit to mhdawson/podman-desktop-extension-ai-lab that referenced this pull request Nov 22, 2024
…-framework-3

upping worker and running bootc install
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Provide workflow for playground image
2 participants