-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support extension restart and manual deletion of pod #335
support extension restart and manual deletion of pod #335
Conversation
f86dacb
to
82cb3c0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still a bit puzzled about the buttons and their behaviors TBH (i would expect the same behaviors we have for podman machines - the stop and restart button to be enabled when the env is running, or the delete when it's stopped and so on.. ).
@mairin It would be great to know how this should work bc otherwise it's hard to make an objective review and it's just personal taste
My thoughts for the moment as i don't know how it should effectively work:
- i have a recipe pod created yesterday (it is stopped now), i open my ai-studio and i see this. I would expect to being able to click the start button and have the restart disabled.
- I click on restart. Everything is built again correctly but eventually i see. Shouldn't the different states/run application summary be hidden?
- I stop the pod manually and i see. I would expect to see the name of the pod without the old states/summary
- i delete the pod and i see. Shouldn't we show again the Run application button?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now, because the extension is managing the state of the containers in the pod (it restarts the app container when the model is running), it is not interesting to just restart a stopped pod, because it will never restart correctly. The only way for now is to delete and recreate the pod (with the Restart button) Bu I agree that when the pod is stopped, the display should reflect it better
Right, I need to work on the Stop status of a pod
That's an open question we started discuss on #289 (comment) |
…t manually stopped pod
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
You should also update the message when stopping the env. It says Delete the environment "${recipe.name}"?
. It should say Stop ...
.
Good catch, thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👏 !!
tested and works fine when
- still starting and deleting from cli
- still starting and deleting from podman
Intel Habanalabs bootc image
What does this PR do?
application being deployed and extension restarted: because AI Studio manages the restart of the app container, the pod is not ok, it needs to be deleted by user => This deletion is correctly supported and the Play button is enabled again.
application deployed and correctly running, and extension restarted => the status "Pod running" is displayed in the Environments page and the pod name is displayed in the "Application Details" block.
application being deployed or correctly running, and the pod is deleted manually => tasks cleared and replaced by a single 'Pod deleted manually', visible in "Application Details" (not in Environments, as the line has been deleted)
replaced delete with stop button
matching pod is deleted before to start a new one
handle pod stopped manually
handle machine stopped manually
Screenshot / video of UI
What issues does this PR fix or reference?
Fixes #328
How to test this PR?