Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/contextdir optional #236

Merged
merged 8 commits into from
Feb 7, 2024

Conversation

axel7083
Copy link
Contributor

@axel7083 axel7083 commented Feb 6, 2024

What does this PR do?

Make contextdir optional by using parent directory of studio-ia.yaml file if not value is provided.

Screenshot / video of UI

What issues does this PR fix or reference?

Fixes #171

How to test this PR?

  • Unit tests have been added

Signed-off-by: axel7083 <[email protected]>
Signed-off-by: axel7083 <[email protected]>
@axel7083 axel7083 requested a review from a team as a code owner February 6, 2024 14:28
Copy link
Contributor

@feloy feloy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(forgot to send my review earlier)

packages/backend/src/managers/applicationManager.ts Outdated Show resolved Hide resolved
packages/backend/src/models/AIConfig.ts Outdated Show resolved Hide resolved
Signed-off-by: axel7083 <[email protected]>
Signed-off-by: axel7083 <[email protected]>
Copy link
Contributor

@lstocchi lstocchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: axel7083 <[email protected]>
@axel7083 axel7083 merged commit 29f6940 into containers:main Feb 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

contexdir in ai-studio.yaml is mandatory
3 participants