fix: wait until playground is initialized #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgolovin
approved these changes
Feb 2, 2024
|
The test are failing with heap memory limit. Is the |
|
I cannot make it work on mac. Let me add some sleep between requests to be able to check the logs, or I get flooded by logs |
It is and seems related to another (flaky ?) test |
feloy
reviewed
Feb 5, 2024
Should be fixed now |
feloy
reviewed
Feb 5, 2024
Fixes containers#147 Signed-off-by: Jeff MAURY <[email protected]>
Co-authored-by: Denis Golovin <[email protected]>
Signed-off-by: Jeff MAURY <[email protected]>
Signed-off-by: Jeff MAURY <[email protected]>
Signed-off-by: Jeff MAURY <[email protected]>
axel7083
reviewed
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #147
What does this PR do?
Wait until the playground container is properly initialized
Screenshot / video of UI
N/A
What issues does this PR fix or reference?
Fixes #147
How to test this PR?
Start a playground