-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: using podman-desktop modals instead of custom one #210
feat: using podman-desktop modals instead of custom one #210
Conversation
Signed-off-by: axel7083 <[email protected]>
Not related directly to this PR, but the following podman-desktop/podman-desktop#5744 would be a nice touch ! |
Signed-off-by: axel7083 <[email protected]>
Signed-off-by: axel7083 <[email protected]>
Signed-off-by: axel7083 <[email protected]>
packages/frontend/src/lib/table/model/ModelColumnActions.svelte
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that if there is some error while deleting we do not show anything to the user.
Maybe this can be done in a follow-up PR as you're just replacing the modal but, thinking at this future change, wouldn't it be better to await the showWarningMessage and have the deleteLocalModel
outside the then?
@lstocchi Yes, we could also use ShowError api inside the backend and try catch the deletion. But this is not in the scope of this PR, as the current behavior is not supporting it either |
So my first thought was wrong, by looking at the code we have a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you could change the function "style" as commented by Jeff/Florent i'm good with it
Signed-off-by: axel7083 <[email protected]>
Signed-off-by: axel7083 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Send output from bootc-image-builder to build subdir
What does this PR do?
Uses the Podman-Desktop provided modals instead of custom one.
Screenshot / video of UI
podman-desktop-delete-modals.mp4
What issues does this PR fix or reference?
Fixes #203
How to test this PR?