Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wait for the model service to be started before checking the sam… #196

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

lstocchi
Copy link
Contributor

…ple app

@lstocchi lstocchi marked this pull request as ready for review January 30, 2024 17:45
@lstocchi lstocchi requested a review from jeffmaury January 30, 2024 17:45
@lstocchi
Copy link
Contributor Author

lstocchi commented Jan 30, 2024

@jeffmaury rebased and fixed tests

Copy link
Contributor

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested with chatbot and summarizer

@jeffmaury jeffmaury added this to the 0.1.0 milestone Jan 30, 2024
@lstocchi lstocchi merged commit a1cb858 into containers:main Jan 30, 2024
3 checks passed
@lstocchi lstocchi deleted the fixStartApp branch January 30, 2024 18:50
mhdawson pushed a commit to mhdawson/podman-desktop-extension-ai-lab that referenced this pull request Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants