fix: button must have a spinner when progress true

[axel7083]

Description

Fixe Button svelte component to have proper spinner when progress true

Screenshots

podman-spinner-progress.mp4

Related issues

Fixes #188

Tests

• Regression tests has been added

[axel7083]

cc @slemeur

[benoitf]

I think that when modifying code duplicated from the core of podman desktop you should first discuss in the upstream before applying what I call 'downstream/ai-studio' library because your manual change will be easily dropped/forgotten when for example ai-studio' would use the podman desktop button component

[benoitf]

here for example you could use an icon for the 'send request' button as well
When in progress, icon will be replaced by the spinner

[axel7083]

I think that when modifying code duplicated from the core of podman desktop you should first discuss in the upstream before applying what I call 'downstream/ai-studio' library because your manual change will be easily dropped/forgotten when for example ai-studio' would use the podman desktop button component

I am a bit reluctant to be force to keep some kind of upstream/downstream for the UI, when we usually already modify them a lot when we copy/past the components, as we are trying to limit the duplicate code. I hope, as well that in the future, the podman-desktop library will be more "standard" and such property as "inProgress" will be change, to match for example other component using "loading". They are a lot of inconsistency already, and the day we will have to migrate to the "podman-desktop" shared library will probably not be as easy as just replace the components, because most of them will be probably changed and adapted to be generics.

here for example you could use an icon for the 'send request' button as well When in progress, icon will be replaced by the spinner

But why would be want to spinner icon to be displayed if we provide the "inProgress" property to true...

Finally, I would prefer we have a clear discussion on the matter, and clearly state, what we want to do, if we want to keep the same components and property (and do not change the implementation) or we can customize them, this is an issue not related to this specific PR and should be addressed as we are already often changing them.

cc @jeffmaury

[jeffmaury]

LGTM