Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add packaging guide #185

Merged
merged 7 commits into from
Feb 8, 2024
Merged

docs: add packaging guide #185

merged 7 commits into from
Feb 8, 2024

Conversation

jeffmaury
Copy link
Contributor

Fixes #123

PACKAGING-GUIDE.md Outdated Show resolved Hide resolved
PACKAGING-GUIDE.md Outdated Show resolved Hide resolved
PACKAGING-GUIDE.md Outdated Show resolved Hide resolved
PACKAGING-GUIDE.md Outdated Show resolved Hide resolved
jeffmaury and others added 4 commits January 30, 2024 15:46
Co-authored-by: Luca Stocchi <[email protected]>
Co-authored-by: Luca Stocchi <[email protected]>
Co-authored-by: Luca Stocchi <[email protected]>
Co-authored-by: Luca Stocchi <[email protected]>
PACKAGING-GUIDE.md Outdated Show resolved Hide resolved

#### Recipe configuration file

The configuration file is called ```ai-studio.yaml``` and follows the following syntax.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where do we need to place this file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the config attribute of a recipe. Maybe I should repeat or link to the definition

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think it would be nice to have the context, for example saying: 'The configuration file for a recipe, as defined in the config field ...'

PACKAGING-GUIDE.md Outdated Show resolved Hide resolved
PACKAGING-GUIDE.md Outdated Show resolved Hide resolved
PACKAGING-GUIDE.md Outdated Show resolved Hide resolved
Copy link
Contributor

@lstocchi lstocchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeffmaury jeffmaury requested a review from feloy February 1, 2024 07:47
@jeffmaury jeffmaury requested a review from a team as a code owner February 2, 2024 10:57
@jeffmaury jeffmaury merged commit 495fd51 into containers:main Feb 8, 2024
3 checks passed
@jeffmaury jeffmaury deleted the GH-123 branch February 8, 2024 12:41
mhdawson pushed a commit to mhdawson/podman-desktop-extension-ai-lab that referenced this pull request Nov 22, 2024
Publish test-make-targets job results
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Packaging documentation
3 participants