Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: start pod with sample and model service #144

Merged
merged 1 commit into from
Jan 26, 2024
Merged

feat: start pod with sample and model service #144

merged 1 commit into from
Jan 26, 2024

Conversation

lstocchi
Copy link
Contributor

This PR starts the pod and checks the model service so when it's up it can restart the sample app container

jeffmaury
jeffmaury reviewed Jan 26, 2024
View reviewed changes
Copy link
Contributor

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested on Win11 but I still have the original containers (out of the pod) being there after the pod is started. Now testing on MacOS/QEMU

@lstocchi
Copy link
Contributor Author

@jeffmaury that is a different issue #131. I think we need to update podman desktop api

@feloy
Copy link
Contributor

feloy commented Jan 26, 2024

Works for me on mac/qemu

@jeffmaury
Copy link
Contributor

@jeffmaury that is a different issue #131. I think we need to update podman desktop api

Can't we delete them once the pod is fully started ? But that maybe a follow up PR

@jeffmaury
Copy link
Contributor

Tested on MacOS/QEMU as well.

@lstocchi
Copy link
Contributor Author

Can't we delete them once the pod is fully started ? But that maybe a follow up PR

Yes if we want to add a temporary solution until we have a cleaner one we can delete them easily after creating the pod

@lstocchi
Copy link
Contributor Author

@jeffmaury if you approve i merge it

@lstocchi lstocchi requested a review from jeffmaury January 26, 2024 10:59
@lstocchi lstocchi enabled auto-merge (squash) January 26, 2024 11:14
@lstocchi lstocchi removed the request for review from axel7083 January 26, 2024 11:14
@lstocchi lstocchi disabled auto-merge January 26, 2024 11:14
@lstocchi lstocchi enabled auto-merge (squash) January 26, 2024 11:15
@lstocchi lstocchi linked an issue Jan 26, 2024 that may be closed by this pull request
Start the pod with sample app and model service #129
Closed
@lstocchi lstocchi merged commit 6c2133e into containers:main Jan 26, 2024
3 checks passed
@lstocchi lstocchi deleted the i129 branch January 26, 2024 11:21
mhdawson pushed a commit to mhdawson/podman-desktop-extension-ai-lab that referenced this pull request Nov 22, 2024
@sallyom
Merge pull request containers#144 from MichaelClifford/contributors
562f8ec 
add CONTRIBUTING.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feloy feloy feloy approved these changes

@jeffmaury jeffmaury jeffmaury approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Start the pod with sample app and model service
3 participants
@lstocchi @feloy @jeffmaury