-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix issue on applehv when mounting volume (#130) #135
Conversation
Signed-off-by: lstocchi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@jeffmaury have you run it on your MAC? Bc it does not work for @feloy |
Closing for the moment as this does not work. I had a dirty env apparently. If you execute the mount using the cli it update volume permissions and then it works fine with desktop. |
I'm reopening to track the issue. context:
As far as I can understand, mounting the file with the The steps to investigate:
Details on the file: |
A directory mounted with :z will cause podman and other container tools to run a We have made a change in Podman to automatically mount all volumes from outside the VM to label them as container_file_t:s0 by default. This means that the containers can read/write all volumes mounted into the VM, and you o longer need to do :z or :Z. If you do a :Z or have previously done a :Z to a volume, then this volume will continue to be only useable by the container with the same SElinuc MCS Label. |
@@ -137,6 +137,9 @@ export class ApplicationManager { | |||
Target: `/${modelName}`, | |||
Source: modelPath, | |||
Type: 'bind', | |||
BindOptions: { | |||
Propagation: 'z', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is not compatible with the Podman Desktop API
Closing as it should work by using the updated podman-desktop api -> #231 |
scheduled workflow for testing
This patch adds the :z bind option when mounting the volume to fix the issue on applehv.