-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use FormPage for Import Model page #1230
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -34,7 +34,7 @@ onMount(() => { | |||
</script> | |||
|
|||
<Route path="/*" isAppMounted="{isMounted}" let:meta> | |||
<main class="flex flex-col w-screen h-screen overflow-hidden bg-charcoal-700"> | |||
<main class="flex flex-col w-screen h-screen overflow-hidden bg-[var(--pd-content-bg)]"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am wondering if we should not use var(--pd-invert-content-bg)
as in the preferences, it is what is used however this would make the card of the form hidden :/
Do you mean the vertical shadow between the 2 zones? If so, this issue tracks the problem: podman-desktop/podman-desktop#7549 |
Signed-off-by: Philippe Martin <[email protected]>
053fb3d
to
40f8b2c
Compare
I double-checked, and for me the 2 colors were already before really the same (#343434), but the shadow in the middle makes one think they are different |
What does this PR do?
Updtae the "Import Model" page to use the dedicated FormPage component instead of NavPage
Also change a few colors to support light mode (except colors in the form itself)
Screenshot / video of UI
What issues does this PR fix or reference?
Fixes #1229
How to test this PR?
Navigate to Catalog > Import