Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: events duplication #1207

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

axel7083
Copy link
Contributor

What does this PR do?

Introduced by #1175, we duplicate proxy events by subscribing two time to the webview messages.

Screenshot / video of UI

What issues does this PR fix or reference?

Fixes #1206

How to test this PR?

  • Regression test has been added

Signed-off-by: axel7083 <[email protected]>
@axel7083 axel7083 requested review from benoitf and a team as code owners June 12, 2024 11:37
@axel7083 axel7083 requested a review from feloy June 12, 2024 11:37
@axel7083 axel7083 mentioned this pull request Jun 12, 2024
1 task
@axel7083 axel7083 requested review from jeffmaury and lstocchi June 12, 2024 11:38
Copy link
Contributor

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@axel7083 axel7083 merged commit 0876c08 into containers:main Jun 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(api): RPC events are duplicated
2 participants