-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: revamp recipes list page #1199
feat: revamp recipes list page #1199
Conversation
Signed-off-by: axel7083 <[email protected]>
Signed-off-by: axel7083 <[email protected]>
14faeac
to
0c99854
Compare
Signed-off-by: axel7083 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for the path inside the card I don't know if we should truncate the middle of the path so we see the beginning and the end of the path but it can also be a bad idea !
We will probably iterate a bit on this with Emma when she will be back ! I keep your remark in mind, I also feel a bit weird with the current path. I cannot put a tooltip, because there is like overflow-hidden everywhere on the page... |
Yes can't we have the full path as tooltip ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM comment wise
I find the recipe status button/indicator disturbing. It's ok when the recipe is downloadable, but when it is downloaded, the button is still active and does nothing. Also, a tooltip would help understand the meaning |
Signed-off-by: axel7083 <[email protected]>
Following @feloy advise, I revised the design of the icon.
demo-revamp-recipes-page.mp4
I was able to make it works, as the path is often too big, it go offscreen, I tried to play with the tooltip position (left, right etc.) but depending on which card, it get always cut offscreen... |
I had a little fun with finding a nice way of allowing the user to see the full path, and I though: what if the text automatically scroll when hovering text-hover-scroll.mp4if this idea please some people, I could make another PR to include it, what do you think @jeffmaury @benoitf @deboer-tim
|
Seems to me that it is more common to have a UI glitch (tooltip) that shows the full path when a specific UI action is taken (hover,...). Here the con that I see is that the full path is not displayed entirely but that's still an improvement |
Also, one important thing for the user I think is to be able to copy the path string. If the path is not displayed completely, the copy is not effective. The tooltip won't help either, as its content cannot be copied. Should we add a copy button? (same as @axel7083 added in his initial message I guess) |
Merging for now this PR and I will open an issue for follow up here #1214 |
What does this PR do?
Following one of the mockup in #1126, improving the recipes card.
Notable change
Screenshot / video of UI
What issues does this PR fix or reference?
Fixes partially #1126
How to test this PR?