Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adopt Spinner from svelte ui library #1197

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

jeffmaury
Copy link
Contributor

Fixes #963

What does this PR do?

Use Spinner UI component from UI library

Screenshot / video of UI

N/A

What issues does this PR fix or reference?

#963

How to test this PR?

N/A

@jeffmaury jeffmaury requested review from benoitf and a team as code owners June 11, 2024 14:14
@jeffmaury jeffmaury requested a review from feloy June 11, 2024 14:14
Copy link
Collaborator

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should ./button/Spinner.svelte be removed then ?

Signed-off-by: Jeff MAURY <[email protected]>
@jeffmaury
Copy link
Contributor Author

should ./button/Spinner.svelte be removed then ?

Fixed

@jeffmaury jeffmaury merged commit 4d699f1 into containers:main Jun 12, 2024
4 checks passed
@jeffmaury jeffmaury deleted the GH-963 branch June 12, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adopt Spinner UI component
4 participants