Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use Table component from ui package #1193

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Conversation

lstocchi
Copy link
Contributor

What does this PR do?

This PR deletes the Table/SimpleColumn component and replace them with the one inside the ui package.

There was an issue though during the refactoring. The header of the table had a different color bc we customized it in ai lab.
There were two solutions to fix this:

  1. update the Table in the ui package to allow customizing the color
  2. update the background in ai-lab to be in sync with the rest of podman-desktop

I opted for the second as it will come in handy for the light mode

Screenshot / video of UI

Nothing changes. I recorded this gif to show you the extension with the new bg color. It is the same used in desktop
new_bg_color

What issues does this PR fix or reference?

it resolves #969

How to test this PR?

  1. nothing should change except some colors. Just navigate through ai lab to see if you notice some bad style

Signed-off-by: lstocchi <lstocchi@redhat.com>
@lstocchi lstocchi requested review from benoitf and a team as code owners June 11, 2024 10:02
@lstocchi lstocchi requested review from axel7083 and jeffmaury June 11, 2024 10:02
Copy link
Contributor

@axel7083 axel7083 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job, the change of background was the best solution !

Copy link
Contributor

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lstocchi lstocchi merged commit 1a8eade into containers:main Jun 11, 2024
4 checks passed
@lstocchi lstocchi deleted the i969 branch June 11, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adopt Table/SimpleColumn UI component
3 participants