watch local models #119
Merged
watch local models #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feloy
force-pushed
the
feat-116/watch-models
branch
2 times, most recently
from
fb335cc to
13d3428
Compare
feloy
force-pushed
the
feat-116/watch-models
branch
from
13d3428 to
ac9a732
Compare
axel7083
approved these changes
Jan 24, 2024
| await reloadLocalModels(); | ||
| } | ||
|
|
||
| getModelsInfo() { |
There was a problem hiding this comment.
Do we do not display models that are not in the catalog ?
There was a problem hiding this comment.
Right, we are displaying in the Models list only the models on the disk AND on the catalog, as the catalog is the source for many information (model name, license, etc).
There was a problem hiding this comment.
I would rather still list the models, and show some "?" or information/warning icon the missing field rather than ignoring them
There was a problem hiding this comment.
@slemeur what do you think?
mhdawson
pushed a commit
to mhdawson/podman-desktop-extension-ai-lab
that referenced
this pull request
Nov 22, 2024
…e-containers Embed workload bootable containers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the extension watch the folder containing the models, and updates the UI accordingly.
Fixes #116