Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: discussion recipe models relation #1180

Closed

Conversation

axel7083
Copy link
Contributor

@axel7083 axel7083 commented Jun 7, 2024

See docs/proposals/recipe-models-relation.md

Related to #1111

@axel7083 axel7083 requested review from benoitf and a team as code owners June 7, 2024 12:19
@axel7083 axel7083 requested a review from feloy June 7, 2024 12:19
Signed-off-by: axel7083 <[email protected]>
@jeffmaury
Copy link
Contributor

My 2 cents:

  • the cuda and other variants shoud be handled by the inferenceprovider based on the environment
  • inference providers should be registered according to the backend they support
  • I don't see the use case for llama.cpp and ollama as they are the same
  • I'm +1 for backend property

Copy link
Contributor

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment

@axel7083
Copy link
Contributor Author

My 2 cents:

  • the cuda and other variants shoud be handled by the inferenceprovider based on the environment

Okey with this proposition

  • I don't see the use case for llama.cpp and ollama as they are the same

When I say llama.cpp I am thinking about our own image build by the recipe team. Because they probably do not need the same arguments, environment variables etc. They should be consider as two separate provider.

  • I'm +1 for backend property

Good, then #1186

@axel7083
Copy link
Contributor Author

Closing as resolved

@axel7083 axel7083 closed this Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants