Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Podman Desktop Extension navigation and installation #1156

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Fix Podman Desktop Extension navigation and installation #1156

merged 1 commit into from
Jun 4, 2024

Conversation

ScrewTSW
Copy link
Member

@ScrewTSW ScrewTSW commented Jun 4, 2024 •
edited
Loading

What does this PR do?

  • Fixes navigation changes in tests
  • Synchronizes architecture with BootC extension

Screenshot / video of UI

N/A

What issues does this PR fix or reference?

#978

How to test this PR?

  • compile Podman Desktop from source in e2e test mode (yarn test:e2e:build)
  • export PODMAN_DESKTOP_ARGS=<path_to_podman_desktop_sources>
  • change directory to tests/playwright
  • run yarn test:e2e

Additional Context

Example test output:

...

 ✓ src/ai-lab-extension.spec.ts (4) 14894ms
   ✓ AI Lab extension installation and verification (4) 10796ms
     ✓ AI Lab extension installation (2) 10665ms
       ✓ Open Settings -> Extensions page 512ms
       ✓ Install AI Lab extension 10153ms
     ✓ AI Lab extension verification (2)
       ✓ Verify AI Lab is present in notification bar and open it
       ✓ Verify AI Lab is running

 Test Files  1 passed (1)
      Tests  4 passed (4)
   Start at  09:25:57
   Duration  15.91s (transform 129ms, setup 475ms, collect 26ms, tests 14.89s, environment 0ms, prepare 156ms)

Done in 18.61s.

@ScrewTSW ScrewTSW requested review from benoitf and a team as code owners June 4, 2024 07:24
@ScrewTSW ScrewTSW requested a review from axel7083 June 4, 2024 07:24
@odockal odockal self-requested a review June 4, 2024 08:47
@ScrewTSW ScrewTSW force-pushed the 978-extend-basic-smoke-test-to-verify-ai-app-demo-scenario branch from 4901d7a to 21516d9 Compare June 4, 2024 12:47
@ScrewTSW
chore(test): renaming test file to be in sync with bootc, fixing exte…
29399eb 
…nsion installation

Signed-off-by: Tibor Dancs <[email protected]>

chore(fixup): addressing vladimir lazar review comment

Signed-off-by: Tibor Dancs <[email protected]>
@ScrewTSW ScrewTSW force-pushed the 978-extend-basic-smoke-test-to-verify-ai-app-demo-scenario branch from 21516d9 to 29399eb Compare June 4, 2024 13:07
@ScrewTSW ScrewTSW merged commit a8abad1 into containers:main Jun 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbr7 cbr7 cbr7 approved these changes

@axel7083 axel7083 axel7083 approved these changes

@odockal odockal odockal approved these changes

@benoitf benoitf Awaiting requested review from benoitf benoitf is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ScrewTSW @odockal @axel7083 @cbr7