Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: display error if not matching containers is found #115

Merged
merged 8 commits into from
Jan 25, 2024
Merged

feat: display error if not matching containers is found #115

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f5fa60c
feat: display error if not matching containers is found
axel7083 Jan 23, 2024
d7759db
tests: ensuring an error is thrown when no containers have been found
axel7083 Jan 23, 2024
c98fa5c
feat: display error if not matching containers is found
axel7083 Jan 23, 2024
7117692
tests: ensuring an error is thrown when no containers have been found
axel7083 Jan 23, 2024
4862aa3
fix: tests
axel7083 Jan 24, 2024
1b86262
Merge branch 'main' into feature/fail-loading-config-if-no-matching-c…
axel7083 Jan 25, 2024
ae21792
Merge remote-tracking branch 'origin/feature/fail-loading-config-if-n…
axel7083 Jan 25, 2024
f30c251
fix: bad conflict resolution
axel7083 Jan 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions packages/backend/src/managers/applicationManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,15 +132,21 @@ export class ApplicationManager {
throw new Error('Cannot load configuration file.');
}

// Mark as success.
loadingConfiguration.state = 'success';
taskUtil.setTask(loadingConfiguration);

// Filter the containers based on architecture
const filteredContainers = aiConfig.application.containers.filter(
container => container.arch === undefined || container.arch === arch(),
);

if (filteredContainers.length > 0) {
// Mark as success.
loadingConfiguration.state = 'success';
axel7083 marked this conversation as resolved.
Show resolved Hide resolved
taskUtil.setTask(loadingConfiguration);
} else {
// Mark as failure.
loadingConfiguration.state = 'error';
taskUtil.setTask(loadingConfiguration);
}

axel7083 marked this conversation as resolved.
Show resolved Hide resolved
const localModels = this.getLocalModels();
if (!localModels.map(m => m.id).includes(model.id)) {
// Download model
Expand Down
Loading