Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Remove the old GPUManager code detecting the Nvidia GPU using
nvidia-smi
and replace it with a generic worker system.This PR is adding the
WinGPUDetector
worker. This worker is responsible of detecting the GPUs available on windows.How
We need two information, the name and the VRAM available for each GPU, sadly windows is crap123, and they don't fix their code1, so we have to read the registry4 to access the exact value of the VRAM for each GPU detected.
Other solution do not provide accurate value3.
Screenshot / video of UI
What issues does this PR fix or reference?
Related to https://github.com/containers/podman-desktop-internal/issues/270
Fixes #1144
How to test this PR?
Manually
Adding the following in the studio.ts file (activate function)
Example output
Footnotes
Msinfo32.exe reports an unexpected value for the Display Adapter RAM when the graphics adapter has 2 GB or more of dedicated video memory https://learn.microsoft.com/en-us/troubleshoot/windows-client/setup-upgrade-and-drivers/msinfo32-report-wrong-display-adapter-ram ↩ ↩2
Windows is crap https://superuser.com/questions/1461858/fetch-correct-vram-for-gpu-via-command-line-on-windows ↩
Windows is crap https://stackoverflow.com/questions/68274009/wmi-win32-videocontroller-ram-4gb-limit ↩ ↩2
Windows registry values https://learn.microsoft.com/fr-fr/windows-hardware/drivers/install/system-defined-device-setup-classes-available-to-vendors ↩