refactor: move getLocalModels to ModelsManager #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feloy
force-pushed
the
refacto/getLocalModels
branch
3 times, most recently
from
0347457 to
0ef4670
Compare
feloy
changed the title
benoitf
approved these changes
Jan 23, 2024
| import type { GitManager } from './gitManager'; | ||
| import os from 'os'; | ||
| import fs, { Stats, type Dirent } from 'fs'; | ||
| import path from 'path'; | ||
| import fs from 'fs'; |
There was a problem hiding this comment.
Suggested change
| import fs from 'fs'; | |
| import fs from 'node:fs'; |
There was a problem hiding this comment.
using node: prefix is recommended for all the 'internal' packages
it's to avoid for example that you use https://www.npmjs.com/package/fs
| export class ModelsManager { | ||
| constructor(private appUserDirectory: string) {} | ||
|
|
||
| getLocalModels(): LocalModelInfo[] { |
There was a problem hiding this comment.
just a question.
It seems it's a lazy initialization and without cache, do we need to read the files each time we're called or you're planning to read it eagerly or have a cache
There was a problem hiding this comment.
We could watch the folder for changes
There was a problem hiding this comment.
Good point, I created #116
feloy
force-pushed
the
refacto/getLocalModels
branch
from
0ef4670 to
1c6a778
Compare
mhdawson
pushed a commit
to mhdawson/podman-desktop-extension-ai-lab
that referenced
this pull request
Nov 22, 2024
model_servers workflow renamed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.