feat: add checksum verification for downloaded models #1078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rebased. Ready to be reviewed. |
feloy
approved these changes
May 14, 2024
jeffmaury
requested changes
May 14, 2024
|
@jeffmaury updated |
axel7083
reviewed
May 14, 2024
axel7083
reviewed
May 14, 2024
axel7083
reviewed
May 14, 2024
axel7083
reviewed
May 14, 2024
|
Moved the error displayed on the top as suggested by @axel7083 . TBH i preferred the error on the row as it was in line with desktop but as we rely on the top banner for showing the download in progress it makes sense to show it there. Updated the gif on the first post |
axel7083
reviewed
May 15, 2024
axel7083
reviewed
May 15, 2024
Signed-off-by: lstocchi <[email protected]>
Signed-off-by: lstocchi <[email protected]>
Signed-off-by: lstocchi <[email protected]>
Signed-off-by: lstocchi <[email protected]>
Signed-off-by: lstocchi <[email protected]>
axel7083
approved these changes
May 15, 2024
|
@jeffmaury if it's good for you, it can be merged. Give it a look when you have time |
jeffmaury
approved these changes
May 16, 2024
Signed-off-by: lstocchi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It display an error if the downloaded model has a different sha than the expected value
Screenshot / video of UI
On the models page
On the recipe page (it still shows the old error mesage with the double
Something went wrongbut it has been cleaned)What issues does this PR fix or reference?
it resolves #977
How to test this PR?