Do not download model again #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoitf
approved these changes
Jan 22, 2024
feloy
force-pushed
the
feat-18/dont-reload-model
branch
2 times, most recently
from
35f3046 to
9376725
Compare
feloy
commented
Jan 22, 2024
Comment on lines
18
to
49
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| vi.spyOn(fs, 'readdirSync').mockImplementation((dir: string): any => { | ||
| // TODO(feloy): fix any |
There was a problem hiding this comment.
The difficulty with readdirSync is that it returns either Dirent[] or string[] depending on the options passed. I'm not sure how to handle this without using any here...
There was a problem hiding this comment.
const readdirSyncMock: MockInstance<[path: fs.PathLike], string[]| fs.Dirent[]> = vi.spyOn(fs, 'readdirSync') as unknown as MockInstance<[path: fs.PathLike], string[]| fs.Dirent[]>;
readdirSyncMock.mockImplementation((path: fs.PathLike) => {There was a problem hiding this comment.
(that said on unit test I'm fine to use any type)
feloy
force-pushed
the
feat-18/dont-reload-model
branch
2 times, most recently
from
6a0c083 to
8f39872
Compare
feloy
force-pushed
the
feat-18/dont-reload-model
branch
3 times, most recently
from
eec5015 to
ccb3533
Compare
feloy
force-pushed
the
feat-18/dont-reload-model
branch
from
ccb3533 to
0224f4f
Compare
mhdawson
pushed a commit
to mhdawson/podman-desktop-extension-ai-lab
that referenced
this pull request
Nov 22, 2024
Generalize test requirements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18