feat: allows to set a custom folder where to download models #1069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lstocchi <[email protected]>
1 task
feloy
reviewed
May 10, 2024
| "type": "string", | ||
| "format": "folder", | ||
| "default": "", | ||
| "description": "Custom path where to download models. Note: The extension must be restarted for changes to take effect. (Default is blank)" |
There was a problem hiding this comment.
It's not very user friendly to need to restart ht eextension after the user changes the setting. The AI Lab extension could use the onDidChangeConfiguration to detect when the setting is changed, and update the #modelsDir at this moment. Or is there something else that needs to be initialized at init time, and cannot be updated at this moment?
There was a problem hiding this comment.
No there should be no problem at init time, we would just need to dispose the old watchers i guess. My thought was to behave similarly to the podman binary path setting which is only read at activation. As i don't think this setting will be used frequently.
feloy
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It allows to set a custom folder where to download models.
Right now, the settings it is just a textbox where the user has to copy/paste the path. It will need the PR podman-desktop/podman-desktop#7135 to be merged to switch to a file component
Screenshot / video of UI
N/A
What issues does this PR fix or reference?
it resolves #51
How to test this PR?