Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps-dev): bump eslint-plugin-sonarjs from 0.25.1 to 1.0.3 #1060

Merged
merged 2 commits into from
Jun 21, 2024
+7 −7
Merged

build(deps-dev): bump eslint-plugin-sonarjs from 0.25.1 to 1.0.3 #1060

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
12914aa
build(deps-dev): bump eslint-plugin-sonarjs from 0.25.1 to 1.0.3
dependabot[bot] May 6, 2024
c6f6663
fix: update for eslint-plugin-sonarjs 1.0.3
jeffmaury May 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"plugin:import/recommended",
"plugin:import/typescript",
"plugin:etc/recommended",
"plugin:sonarjs/recommended"
"plugin:sonarjs/recommended-legacy"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure to want to include legacy package => not maintained, but since it is linter I am willing to approve it, even tho we should migrate to their 1.0.3

],
"parser": "@typescript-eslint/parser",
"parserOptions": {
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
"eslint-plugin-import": "^2.29.1",
"eslint-plugin-no-null": "^1.0.2",
"eslint-plugin-redundant-undefined": "^1.0.0",
"eslint-plugin-sonarjs": "^0.25.1",
"eslint-plugin-sonarjs": "^1.0.3",
"prettier": "^3.3.2",
"prettier-plugin-svelte": "^3.2.4",
"svelte-check": "^3.8.1",
Expand Down
2 changes: 1 addition & 1 deletion packages/backend/src/registries/TaskRegistry.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ export class TaskRegistry {
* @param taskIds The IDs of the tasks to delete.
*/
deleteAll(taskIds: string[]) {
taskIds.map(taskId => this.tasks.delete(taskId));
taskIds.forEach(taskId => this.tasks.delete(taskId));
this.notify();
}

Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2015,10 +2015,10 @@ eslint-plugin-redundant-undefined@^1.0.0:
dependencies:
"@typescript-eslint/utils" "^6.2.1"

eslint-plugin-sonarjs@^0.25.1:
version "0.25.1"
resolved "https://registry.yarnpkg.com/eslint-plugin-sonarjs/-/eslint-plugin-sonarjs-0.25.1.tgz#0619798dbc27b04fd0a8e6d0fb6adf7fa2cb5041"
integrity sha512-5IOKvj/GMBNqjxBdItfotfRHo7w48496GOu1hxdeXuD0mB1JBlDCViiLHETDTfA8pDAVSBimBEQoetRXYceQEw==
eslint-plugin-sonarjs@^1.0.3:
version "1.0.3"
resolved "https://registry.yarnpkg.com/eslint-plugin-sonarjs/-/eslint-plugin-sonarjs-1.0.3.tgz#423de6f9244c886633ff36183c6fbc9fb1ed867d"
integrity sha512-6s41HLPYPyDrp+5+7Db5yFYbod6h9pC7yx+xfcNwHRcLe1EZwbbQT/tdOAkR7ekVUkNGEvN3GmYakIoQUX7dEg==

eslint-scope@^5.1.1:
version "5.1.1"
Expand Down