Skip to content

Commit

Permalink
fix: add ci for test, lint, format and typecheck
Browse files Browse the repository at this point in the history
Signed-off-by: lstocchi <[email protected]>
  • Loading branch information
lstocchi committed Jan 17, 2024
1 parent 9705b2b commit 96f7fb5
Show file tree
Hide file tree
Showing 37 changed files with 714 additions and 397 deletions.
87 changes: 87 additions & 0 deletions .github/workflows/pr-check.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,87 @@
#
# Copyright (C) 2024 Red Hat, Inc.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#
# SPDX-License-Identifier: Apache-2.0

name: pr-check

on: [pull_request]

jobs:
lint-format-unit:
name: linter, formatters and unit tests / ${{ matrix.os }}
runs-on: ${{ matrix.os }}
timeout-minutes: 40
strategy:
fail-fast: false
matrix:
os: [windows-2022, ubuntu-22.04]
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 18

- name: Get yarn cache directory path (Windows)
if: ${{ matrix.os=='windows-2022' }}
id: yarn-cache-dir-path-windows
run: echo "dir=$(yarn cache dir)" >> ${env:GITHUB_OUTPUT}

- name: Get yarn cache directory path (mac/Linux)
if: ${{ matrix.os=='ubuntu-22.04'}}
id: yarn-cache-dir-path-unix
run: echo "dir=$(yarn cache dir)" >> ${GITHUB_OUTPUT}

- uses: actions/cache@v3
if: ${{ matrix.os=='windows-2022' }}
id: yarn-cache-windows
with:
path: ${{ steps.yarn-cache-dir-path-windows.outputs.dir }}
key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}
restore-keys: |
${{ runner.os }}-yarn-
- uses: actions/cache@v3
if: ${{ matrix.os=='ubuntu-22.04'}}
id: yarn-cache-unix
with:
path: ${{ steps.yarn-cache-dir-path-unix.outputs.dir }}
key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}
restore-keys: |
${{ runner.os }}-yarn-
- name: Execute yarn
run: yarn --frozen-lockfile --network-timeout 180000

- name: Run linter
run: yarn lint:check

- name: Run formatter
run: yarn format:check

- name: Run unit tests
run: yarn test:unit

- name: Run typecheck
run: yarn typecheck

# Check we don't have changes in git
- name: Check no changes in git
if: ${{ matrix.os=='ubuntu-22.04'}}
run: |
if ! git diff --exit-code; then
echo "Found changes in git"
exit 1
fi
8 changes: 7 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,13 @@
"format:fix": "prettier --write \"**/src/**/*.ts\"",
"lint:check": "eslint . --ext js,ts,tsx",
"lint:fix": "eslint . --fix --ext js,ts,tsx",
"test:backend": "vitest run -r packages/backend --passWithNoTests --coverage"
"test:backend": "vitest run -r packages/backend --passWithNoTests --coverage",
"test:shared": "vitest run -r packages/shared --passWithNoTests --coverage",
"test:unit": "npm run test:backend && npm run test:shared",
"typecheck:shared": "tsc --noEmit -p packages/shared/tsconfig.json",
"typecheck:frontend": "tsc --noEmit -p packages/frontend/tsconfig.json",
"typecheck:backend": "tsc --noEmit -p packages/backend/tsconfig.json",
"typecheck": "npm run typecheck:shared && npm run typecheck:frontend && npm run typecheck:backend"
},
"devDependencies": {
"@typescript-eslint/eslint-plugin": "^6.16.0",
Expand Down
Loading

0 comments on commit 96f7fb5

Please sign in to comment.