chore: improve strictness (#1228)

Signed-off-by: axel7083 <[email protected]>

packages/backend/src/managers/applicationManager.spec.ts

@@ -176,7 +176,7 @@ describe('pullApplication', () => {
       }
       return false;
     });
-    vi.spyOn(fs, 'statSync').mockImplementation((path: PathLike) => {
+    vi.spyOn(fs, 'statSync').mockImplementation((path: PathLike): fs.Stats => {
       path = path.toString();
       if (path.endsWith('recipe1')) {
         const stat = new fs.Stats();
@@ -187,6 +187,7 @@ describe('pullApplication', () => {
         stat.isDirectory = () => false;
         return stat;
       }
+      throw new Error('should never be reached');
     });
     vi.spyOn(fs, 'readFileSync').mockImplementation(() => {
       return '';

packages/backend/src/managers/gitManager.spec.ts

@@ -703,12 +703,13 @@ test('getBehindAhead', async () => {
 
 test('getTrackingBranch', async () => {
   const gitmanager = new GitManager();
-  mocks.getConfigMock.mockImplementation(async ({ path }: { path: string }) => {
+  mocks.getConfigMock.mockImplementation(async ({ path }: { path: string }): Promise<string> => {
     if (path === 'branch.my-branch.remote') {
       return 'origin';
     } else if (path === 'branch.my-branch.merge') {
       return 'refs/heads/my-remote-branch';
     }
+    throw new Error('should never been reached');
   });
   const result = await gitmanager.getTrackingBranch('path/to/repository', 'my-branch');
   expect(result).toEqual('origin/my-remote-branch');

packages/backend/src/workers/gpu/WinGPUDetector.spec.ts

@@ -122,5 +122,5 @@ test('perform should handle errors and return an empty list', async () => {
 
   const detector = new WinGPUDetector();
 
-  await expect(detector.perform()).rejects.toThrowError('Failed to get GPU information: test error');
+  await expect(detector.perform()).rejects.toThrowError('Failed to get GPU information: Error: test error');
 });

packages/backend/src/workers/gpu/WinGPUDetector.ts

@@ -77,7 +77,7 @@ export class WinGPUDetector extends WindowsWorker<void, IGPUInfo[]> {
       const values = await this.getValues(subkey);
       return this.extractGpuInfo(values);
     } catch (error) {
-      console.error(`Error processing subkey: ${subkey.key}, error: ${error.message}`);
+      console.error(`Error processing subkey: ${subkey.key}, error: ${error}`);
       return undefined;
     }
   }
@@ -95,7 +95,7 @@ export class WinGPUDetector extends WindowsWorker<void, IGPUInfo[]> {
       const gpuInfos = await Promise.all(gpuInfoPromises);
       return gpuInfos.filter(info => info !== undefined) as IGPUInfo[];
     } catch (error) {
-      throw new Error(`Failed to get GPU information: ${error.message}`);
+      throw new Error(`Failed to get GPU information: ${error}`);
     }
   }
 }

packages/backend/tsconfig.json

@@ -19,13 +19,10 @@
     "paths": {
       "@shared/*": ["../shared/*"]
     },
-    "strictBindCallApply": true,
-    "alwaysStrict": true,
-    "strictFunctionTypes": true,
-    "strictNullChecks": true,
-    "noImplicitThis": true,
-    "noImplicitAny": true,
-    "strictPropertyInitialization": true
+    "strict": true,
+    "noImplicitOverride": true,
+    "noImplicitReturns": true,
+    "noUnusedLocals": true,
   },
   "include": [
     "src",

packages/frontend/src/Route.svelte

@@ -1,7 +1,7 @@
 <script lang="ts">
 import { createRouteObject } from 'tinro/dist/tinro_lib';
 import type { TinroRouteMeta } from 'tinro';
-import { saveRouterState, studioClient } from '/@/utils/client';
+import { saveRouterState } from '/@/utils/client';
 
 export let path = '/*';
 export let fallback = false;

packages/frontend/src/lib/ApplicationActions.svelte

@@ -13,7 +13,6 @@ import type { ApplicationState } from '@shared/src/models/IApplicationState';
 import { router } from 'tinro';
 import DropDownMenu from './DropDownMenu.svelte';
 import FlatMenu from './FlatMenu.svelte';
-import { onMount } from 'svelte';
 export let object: ApplicationState | undefined;
 export let recipeId: string;
 export let modelId: string;

packages/frontend/src/lib/RecipeDetails.svelte

@@ -17,7 +17,6 @@ import { tasks } from '/@/stores/tasks';
 import { filterByLabel } from '/@/utils/taskUtils';
 import PodIcon from '/@/lib/images/PodIcon.svelte';
 import StatusIcon from '/@/lib/StatusIcon.svelte';
-import type { ModelInfo } from '@shared/src/models/IModelInfo';
 import { getApplicationStatus, getApplicationStatusText } from '../pages/applications';
 import { Button, Spinner } from '@podman-desktop/ui-svelte';
 
@@ -57,10 +56,6 @@ const navigateToPod = () => {
   }
 };
 
-function findModel(id: string | undefined): ModelInfo | undefined {
-  return $catalog.models.find(m => m.id === id);
-}
-
 function startApplication() {
   studioClient.pullApplication(recipeId, modelId).catch((err: unknown) => {
     console.error('Something went wrong while pulling AI App', err);

packages/frontend/src/lib/table/application/ColumnRecipe.svelte

@@ -1,20 +1,12 @@
 <script lang="ts">
 import { catalog } from '/@/stores/catalog';
 import { displayPorts } from '/@/utils/printers';
-import { faSquareArrowUpRight } from '@fortawesome/free-solid-svg-icons';
-import { studioClient } from '/@/utils/client';
-import Fa from 'svelte-fa';
 import type { ApplicationState } from '@shared/src/models/IApplicationState';
 
 export let object: ApplicationState;
 
+let name: string | undefined;
 $: name = $catalog.recipes.find(r => r.id === object.recipeId)?.name;
-
-function openApp(port: number) {
-  studioClient.openURL(`http://localhost:${port}`).catch((err: unknown) => {
-    console.error('Something went wrong while opening url', err);
-  });
-}
 </script>
 
 <div class="flex flex-col">

packages/frontend/src/pages/Playground.svelte

@@ -24,7 +24,6 @@ export let playgroundId: string;
 let prompt: string;
 let sendEnabled = false;
 let scrollable: Element;
-let lastIsUserMessage = false;
 let errorMsg = '';
 
 // settings
@@ -41,7 +40,6 @@ $: {
     if (isSystemPrompt(latest) || (isAssistantChat(latest) && !isPendingChat(latest))) {
       sendEnabled = true;
     }
-    lastIsUserMessage = isUserChat(latest);
   } else {
     sendEnabled = true;
   }

packages/frontend/tsconfig.json

@@ -4,6 +4,9 @@
     "target": "esnext",
     "module": "esnext",
     "strict": true,
+    "noImplicitOverride": true,
+    "noUnusedLocals": true,
+    "noImplicitReturns": true,
     "resolveJsonModule": true,
     "preserveValueImports": false,
     "baseUrl": ".",