chore: apply suggestions from code review

Co-authored-by: axel7083 <[email protected]>
containers · Jan 19, 2024 · 3096934 · 3096934
1 parent b31f107
commit 3096934
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/packages/backend/src/models/AIConfig.ts b/packages/backend/src/models/AIConfig.ts
@@ -33,7 +33,7 @@ export interface AIConfig {
 
 export function isString(value: unknown): value is string {
   // eslint-disable-next-line no-null/no-null
-  return (value !== undefined && value !== null && typeof value === 'string') || value instanceof String;
+  return (!!value && typeof value === 'string') || value instanceof String;
 }
 
 export function assertString(value: unknown): string {

diff --git a/packages/shared/src/messages/MessageProxy.ts b/packages/shared/src/messages/MessageProxy.ts
@@ -44,7 +44,7 @@ type UnaryRPC = (...args: unknown[]) => Promise<unknown>;
 export function isMessageRequest(content: unknown): content is IMessageRequest {
   return (
     // eslint-disable-next-line no-null/no-null
-    content !== undefined && content !== null && typeof content === 'object' && 'id' in content && 'channel' in content
+    !!content && typeof content === 'object' && 'id' in content && 'channel' in content
   );
 }
 
@@ -210,9 +210,7 @@ export class RpcBrowser {
 
   isSubscribedMessage(content: any): content is ISubscribedMessage {
     return (
-      content !== undefined &&
-      // eslint-disable-next-line no-null/no-null
-      content !== null &&
+      !!content &&
       'id' in content &&
       'body' in content &&
       this.subscribers.has(content.id)