-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update run.sh script #11
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about adding stuff around CONFIG_PATH as it's never used in the extension
and for the other env variables as well (except MODEL_PATH, HOST and PORT)
so should we not only add
--clip_model_path "None" --chat_format "llama-2"
I removed the code related to the config file |
723498b
to
ac6210b
Compare
Signed-off-by: axel7083 <[email protected]>
Signed-off-by: axel7083 <[email protected]>
Co-authored-by: Florent BENOIT <[email protected]> Signed-off-by: axel7083 <[email protected]>
Signed-off-by: axel7083 <[email protected]>
d694b42
to
c55c6df
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'm still wondering, if ai lab is the only thing using these images if we should not remove env var that are not yet provided by Ai lab like and add them the day it'll be handled but then side question, how ai lab is ensuring that the image is matching the precondition. if I have the extension being installed for a while and update the extension, will it update the image or notify that the service is no longer compliant ? |
I am in favour of keeping them
We have nothing keeping track of the version |
What does this PR do?
The current script in this repository is out of date compared to the one in https://github.com/containers/ai-lab-recipes/blob/main/model_servers/llamacpp_python/src/run.sh
Screenshot / video of UI
What issues does this PR fix or reference?
Related to containers/podman-desktop-extension-ai-lab#825
How to test this PR?
podman build ./chat