Don't create pods/container when registering systemd unit #923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winston-yallow
force-pushed
the
remove-sideeffect-from-systemd-registration
branch
2 times, most recently
from
f969029 to
4399db0
Compare
|
|
p12tic
approved these changes
May 1, 2024
Signed-off-by: Winston <[email protected]>
winston-yallow
force-pushed
the
remove-sideeffect-from-systemd-registration
branch
from
4399db0 to
d31a8b1
Compare
|
Looks like I can override DCO bot, which is reasonable in this case. |
|
Already figured it out, my local git client did the signing wrong. Edited it manually, sorry for the hassle 😅 |
|
Ah, now it's signed as expected by the bot, thanks. |
|
thanks for the fast merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #922 by removing the side effect from the systemd register action.
Contributor Checklist: