Fix, use "service.build.ulimits" when it is present instead of "service.ulimits" #906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camspiers
force-pushed
the
fixes/ulimit-build-args
branch
from
ed43705 to
54561f0
Compare
p12tic
requested changes
Apr 8, 2024
camspiers
force-pushed
the
fixes/ulimit-build-args
branch
3 times, most recently
from
b8c3a97 to
e2bb65b
Compare
|
Hey @p12tic thanks for reviewing the PR. I have updated with unit tests, but I am not 100% on what I have done. At the moment I am testing both that the ulimits are passed correctly to the build command, and that the ulimits are applied during the build. However I could solely test that the right arguments are passed to the build command using the dry-run flag and remove the actual execution of the ulimit command in the build. |
p12tic
force-pushed
the
fixes/ulimit-build-args
branch
from
e2bb65b to
157bcb8
Compare
p12tic
approved these changes
Apr 17, 2024
Signed-off-by: Cam Spiers <[email protected]>
p12tic
force-pushed
the
fixes/ulimit-build-args
branch
from
157bcb8 to
cdcedeb
Compare
|
Rebased and shortened commit message to max 72 chars allowed by git. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
compose-spec/compose-spec#433