-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for enable_ipv6 #749
Conversation
This is important. Please merge. |
Anything preventing this to be merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR looks great, thank you!
We need unit tests for it.
This part https://github.com/containers/podman-compose/blob/main/podman_compose.py#L713C1-L749C34 could be extracted to a separate function. Then a unit tests could be written just like for container_to_args in pytests/test_container_to_args.py
@maxi0604 Just a note that podman-compose has switched to |
Also probably a nitpick, but it would be great if extraction of |
Signed-off-by: Maximilian R <[email protected]>
Signed-off-by: Maximilian R <[email protected]>
Rebased and reordered commits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Fixes #751
This pull request adds support for the
enable_ipv6
network option when creating the network. This is supported bydocker compose
and is contained in the compose-spec [1]. The change simply exposes the--ipv6
option ofpodman network create
PS: One could argue that this should be on by default and only disabled when
enable_ipv6: false
is set, but doing something like that should - if we even choose to do it at all - be delayed at the very least until containers/podman#15850 is fixed.[1] https://github.com/compose-spec/compose-spec/blob/master/06-networks.md#enable_ipv6