Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add device_cgroup_rules support #1085

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

jeremyvisser
Copy link
Contributor

@jeremyvisser jeremyvisser commented Dec 5, 2024

device_cgroup_rules: [] is defined in the Compose file specification, and corresponds to podman run --device-cgroup-rule=

The relevant part of the spec: https://github.com/compose-spec/compose-spec/blob/main/05-services.md#device_cgroup_rules

@p12tic
Copy link
Collaborator

p12tic commented Dec 5, 2024

Looks good, thanks. Could you please add release note to newsfragments directory. See https://github.com/containers/podman-compose/blob/main/newsfragments/README.txt.

"device_cgroup_rules: []" is defined in the Compose file specification,
and corresponds to "podman run --device-cgroup-rule="

Signed-off-by: Jeremy Visser <[email protected]>
@jeremyvisser jeremyvisser force-pushed the fix-device-cgroup-rules branch from 2e3a4c1 to 054c66b Compare December 5, 2024 21:20
@jeremyvisser
Copy link
Contributor Author

Thanks for the prompt. Done.

@p12tic p12tic merged commit 376f081 into containers:main Dec 6, 2024
7 checks passed
@jeremyvisser jeremyvisser deleted the fix-device-cgroup-rules branch December 7, 2024 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants