Skip to content

Commit

Permalink
Add x-podman.no_hosts extension
Browse files Browse the repository at this point in the history
Signed-off-by: Timon de Groot <[email protected]>
  • Loading branch information
tdgroot committed Oct 14, 2024
1 parent 7090de3 commit a265f66
Show file tree
Hide file tree
Showing 4 changed files with 24 additions and 1 deletion.
3 changes: 2 additions & 1 deletion docs/Extensions.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@ The following extension keys are available under container configuration:
* `x-podman.gidmaps` - Run the container in a new user namespace using the supplied GID mapping.

* `x-podman.rootfs` - Run the container without requiring any image management; the rootfs of the
container is assumed to be managed externally.

* `x-podman.no_hosts` - Run the container without creating /etc/hosts file

For example, the following docker-compose.yml allows running a podman container with externally managed rootfs.
```yml
Expand Down
1 change: 1 addition & 0 deletions newsfragments/container-no-hosts.feature
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Add x-podman.no_hosts setting to pass --no-hosts to podman run
2 changes: 2 additions & 0 deletions podman_compose.py
Original file line number Diff line number Diff line change
Expand Up @@ -1254,6 +1254,8 @@ async def container_to_args(compose, cnt, detached=True):
podman_args.extend(["--uidmap", uidmap])
for gidmap in cnt.get('x-podman.gidmaps', []):
podman_args.extend(["--gidmap", gidmap])
if cnt.get("x-podman.no_hosts", False):
podman_args.extend(["--no-hosts"])
rootfs = cnt.get('x-podman.rootfs', None)
if rootfs is not None:
rootfs_mode = True
Expand Down
19 changes: 19 additions & 0 deletions tests/unit/test_container_to_args.py
Original file line number Diff line number Diff line change
Expand Up @@ -249,6 +249,25 @@ async def test_rootfs_extension(self):
],
)

async def test_no_hosts_extension(self):
c = create_compose_mock()

cnt = get_minimal_container()
cnt["x-podman.no_hosts"] = True

args = await container_to_args(c, cnt)
self.assertEqual(
args,
[
"--name=project_name_service_name1",
"-d",
"--network=bridge",
"--network-alias=service_name",
"--no-hosts",
"busybox",
],
)

async def test_env_file_str(self):
c = create_compose_mock()

Expand Down

0 comments on commit a265f66

Please sign in to comment.